From f8739e341bc5babd2dcd8e608d1a2933979fe4e5 Mon Sep 17 00:00:00 2001 From: Felix Roos Date: Mon, 18 Apr 2022 18:57:28 +0200 Subject: [PATCH] respect midi numbers --- packages/core/util.mjs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/core/util.mjs b/packages/core/util.mjs index ba0d00a4..b9f0f2b8 100644 --- a/packages/core/util.mjs +++ b/packages/core/util.mjs @@ -40,16 +40,15 @@ export const getPlayableNoteValue = (event) => { return note; }; -// TODO: make this compatible with midi numbers object values export const getFrequency = (event) => { let { value, context } = event; // if value is number => interpret as midi number as long as its not marked as frequency if (typeof value === 'object' && value.freq) { return value.freq; } - /* if (typeof value === 'number' && context.type !== 'frequency') { + if (typeof value === 'number' && context.type !== 'frequency') { value = fromMidi(event.value); - } else */ if (typeof value === 'string' && isNote(value)) { + } else if (typeof value === 'string' && isNote(value)) { value = fromMidi(toMidi(event.value)); } else if (typeof value !== 'number') { throw new Error('not a note or frequency:' + value);