elias/strudel
1
0
Fork 0
mirror of https://github.com/eliasstepanik/strudel.git synced 2026-01-14 07:08:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

bugfixes for parameter passing

Browse Source
This commit is contained in:
Raphael Forment 2023-10-01 12:02:17 +02:00
parent abff279707
commit e600b91a85
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/superdough/reverb.mjs
View File

@ -3,14 +3,14 @@ import reverbGen from './reverbGen.mjs';
if (typeof AudioContext !== 'undefined') {
AudioContext.prototype.generateReverb = reverbGen.generateReverb;
AudioContext.prototype.createReverb = function(
duration,
audioContext,
duration,
fade,
revlp,
revdim
) {
const convolver = this.createConvolver();
convolver.setDuration = (d) => {
convolver.setDuration = (d, fade, revlp, revdim) => {
this.generateReverb(
{
audioContext,

12
packages/superdough/superdough.mjs
View File

@ -108,29 +108,27 @@ function getDelay(orbit, delaytime, delayfeedback, t) {
let reverbs = {};
function getReverb(orbit, duration = 2) {
function getReverb(orbit, duration = 2, fade, revlp, revdim) {
// If no reverb has been created for a given orbit, create one
if (!reverbs[orbit]) {
const ac = getAudioContext();
const reverb = ac.createReverb(
duration,
getAudioContext(),
duration,
fade,
revlp,
revdim,
);
reverb.connect(getDestination());
console.log(reverb)
reverbs[orbit] = reverb;
}
// Update the reverb duration if needed after instanciation
if (reverbs[orbit].duration !== duration) {
reverbs[orbit] = reverbs[orbit].setDuration(duration);
reverbs[orbit] = reverbs[orbit].setDuration(
duration, fade, revlp, revdim);
reverbs[orbit].duration = duration;
}
return reverbs[orbit];
}
@ -370,7 +368,7 @@ export const superdough = async (value, deadline, hapDuration) => {
// reverb
let reverbSend;
if (room > 0 && size > 0) {
const reverbNode = getReverb(orbit, size);
const reverbNode = getReverb(orbit, size, fade, revlp, revdim);
reverbSend = effectSend(post, reverbNode, room);
}