From 9b32900b96bea1e80f82d3217df30b37b5992411 Mon Sep 17 00:00:00 2001 From: Felix Roos Date: Sun, 31 Dec 2023 16:27:35 +0100 Subject: [PATCH] revert changing default voicing dict for now... --- packages/tonal/voicings.mjs | 6 ++--- test/__snapshots__/examples.test.mjs.snap | 32 +++++++++++------------ 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/packages/tonal/voicings.mjs b/packages/tonal/voicings.mjs index d2c5871c..6f4d334d 100644 --- a/packages/tonal/voicings.mjs +++ b/packages/tonal/voicings.mjs @@ -51,7 +51,7 @@ const triads = { aug: ['1P 3m 5A', '3m 5A 8P', '5A 8P 10m'], }; -const legacyDictionary = { +const defaultDictionary = { // triads '': ['1P 3M 5P', '3M 5P 8P', '5P 8P 10M'], M: ['1P 3M 5P', '3M 5P 8P', '5P 8P 10M'], @@ -77,7 +77,7 @@ export const voicingRegistry = { lefthand: { dictionary: lefthand, range: ['F3', 'A4'], mode: 'below', anchor: 'a4' }, triads: { dictionary: triads, mode: 'below', anchor: 'a4' }, guidetones: { dictionary: guidetones, mode: 'above', anchor: 'a4' }, - legacy: { dictionary: legacyDictionary, mode: 'below', anchor: 'a4' }, + default: { dictionary: defaultDictionary, mode: 'below', anchor: 'a4' }, }; export const setVoicingRange = (name, range) => addVoicings(name, voicingRegistry[name].dictionary, range); @@ -193,7 +193,7 @@ export const voicing = register('voicing', function (pat) { .fmap((value) => { // destructure voicing controls out value = typeof value === 'string' ? { chord: value } : value; - let { dictionary = 'ireal', chord, anchor, offset, mode, n, octaves, ...rest } = value; + let { dictionary = 'default', chord, anchor, offset, mode, n, octaves, ...rest } = value; dictionary = typeof dictionary === 'string' ? voicingRegistry[dictionary] : { dictionary, mode: 'below', anchor: 'c5' }; try { diff --git a/test/__snapshots__/examples.test.mjs.snap b/test/__snapshots__/examples.test.mjs.snap index 536f6ff1..dd7392d1 100644 --- a/test/__snapshots__/examples.test.mjs.snap +++ b/test/__snapshots__/examples.test.mjs.snap @@ -5365,22 +5365,22 @@ exports[`runs examples > example "vibmod" example index 1 1`] = ` exports[`runs examples > example "voicing" example index 0 1`] = ` [ - "[ 0/1 → 1/4 | note:52 ]", - "[ 1/4 → 1/2 | note:60 ]", - "[ 1/2 → 3/4 | note:64 ]", - "[ 3/4 → 1/1 | note:67 ]", - "[ 1/1 → 5/4 | note:57 ]", - "[ 5/4 → 3/2 | note:60 ]", - "[ 3/2 → 7/4 | note:64 ]", - "[ 7/4 → 2/1 | note:69 ]", - "[ 2/1 → 9/4 | note:53 ]", - "[ 9/4 → 5/2 | note:60 ]", - "[ 5/2 → 11/4 | note:65 ]", - "[ 11/4 → 3/1 | note:69 ]", - "[ 3/1 → 13/4 | note:55 ]", - "[ 13/4 → 7/2 | note:62 ]", - "[ 7/2 → 15/4 | note:67 ]", - "[ 15/4 → 4/1 | note:71 ]", + "[ 0/1 → 1/4 | note:64 ]", + "[ 1/4 → 1/2 | note:67 ]", + "[ 1/2 → 3/4 | note:72 ]", + "[ 3/4 → 1/1 | note:76 ]", + "[ 1/1 → 5/4 | note:64 ]", + "[ 5/4 → 3/2 | note:69 ]", + "[ 3/2 → 7/4 | note:72 ]", + "[ 7/4 → 2/1 | note:76 ]", + "[ 2/1 → 9/4 | note:65 ]", + "[ 9/4 → 5/2 | note:69 ]", + "[ 5/2 → 11/4 | note:72 ]", + "[ 11/4 → 3/1 | note:77 ]", + "[ 3/1 → 13/4 | note:62 ]", + "[ 13/4 → 7/2 | note:67 ]", + "[ 7/2 → 15/4 | note:71 ]", + "[ 15/4 → 4/1 | note:74 ]", ] `;