elias/strudel
1
0
Fork 0
mirror of https://github.com/eliasstepanik/strudel.git synced 2026-01-11 21:58:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #196 from tidalcycles/fix-numbers-in-sampler

Browse Source 
Fix numbers in sampler
This commit is contained in:
Felix Roos 2022-09-09 22:04:40 +02:00 committed by GitHub
commit 88e1211762
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/webaudio/webaudio.mjs
View File

@ -70,9 +70,6 @@ const getSoundfontKey = (s) => {
const getSampleBufferSource = async (s, n, note) => {
let transpose = 0;
if (note) {
transpose = toMidi(note) - 36; // C3 is middle C
}
const ac = getAudioContext();
// is sample from loaded samples(..)
const samples = getLoadedSamples();
@ -93,7 +90,9 @@ const getSampleBufferSource = async (s, n, note) => {
if (!note) {
throw new Error('no note(...) set for sound', s);
}
const midiDiff = (noteA) => toMidi(noteA) - toMidi(note);
const midi = typeof note === 'string' ? toMidi(note) : note;
transpose = midi - 36; // C3 is middle C
const midiDiff = (noteA) => toMidi(noteA) - midi;
// object format will expect keys as notes
const closest = Object.keys(bank)
.filter((k) => !k.startsWith('_'))

3
repl/src/prebake.mjs
View File

@ -55,8 +55,9 @@ Pattern.prototype.piano = function () {
return this.clip(1)
.s('piano')
.fmap((value) => {
const midi = typeof value.note === 'string' ? toMidi(value.note) : value.note;
// pan by pitch
const pan = panwidth(Math.min(toMidi(value.note) / maxPan, 1), 0.5);
const pan = panwidth(Math.min(midi / maxPan, 1), 0.5);
return { ...value, pan: (value.pan || 1) * pan };
});
};