elias/strudel
1
0
Fork 0
mirror of https://github.com/eliasstepanik/strudel.git synced 2026-01-16 16:18:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

documenting vibrato and removing broken slide/pitchJump mechanism

Browse Source
This commit is contained in:
Raphael Forment 2023-09-08 13:43:43 +02:00
parent 3431803980
commit 74442b0d76
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/core/controls.mjs
View File

@ -686,6 +686,7 @@ const generic_params = [
['rate'],
// TODO: slide param for certain synths
['slide'],
['slidespeed'],
// TODO: detune? https://tidalcycles.org/docs/patternlib/tutorials/synthesizers/#supersquare
['semitone'],
@ -893,10 +894,13 @@ const generic_params = [
// ZZFX
['zrand'],
['curve'],
['slide'], // superdirt duplicate
['deltaSlide'],
['pitchJump'],
['pitchJumpTime'],
['slide'], // superdirt duplicate
['deltaSlide'],
/**
*
*/
['lfo', 'repeatTime'],
['noise'],
['zmod'],

8
packages/superdough/synth.mjs
View File

@ -42,8 +42,6 @@ export function registerSynthSounds() {
fmwave: fmWaveform = 'sine',
vib = 0,
vibmod = 1,
pitchJump,
pitchJumpSpeed = 1,
} = value;
let { n, note, freq } = value;
// with synths, n and note are the same thing
@ -63,8 +61,6 @@ export function registerSynthSounds() {
freq,
vib,
vibmod,
pitchJump: pitchJump * freq,
pitchJumpSpeed: sustain / pitchJumpSpeed,
partials: n,
});
@ -150,7 +146,7 @@ export function waveformN(partials, type) {
return osc;
}
export function getOscillator({ s, freq, t, vib, vibmod, pitchJump, pitchJumpSpeed, partials }) {
export function getOscillator({ s, freq, t, vib, vibmod, partials }) {
// Additional oscillator for vibrato effect
if (vib > 0) {
var vibrato_oscillator = getAudioContext().createOscillator();
@ -168,7 +164,6 @@ export function getOscillator({ s, freq, t, vib, vibmod, pitchJump, pitchJumpSpe
if (vib > 0) {
o.frequency.value = Number(freq);
slide > 0 && o.frequency.linearRampToValueAtTime(freq + pitchJump, t + pitchJumpSpeed);
var gain = getAudioContext().createGain();
// Vibmod is the amount of vibrato, in semitones
gain.gain.value = vibmod * freq;
@ -186,7 +181,6 @@ export function getOscillator({ s, freq, t, vib, vibmod, pitchJump, pitchJumpSpe
} else {
// Normal operation, without vibrato
o.frequency.value = Number(freq);
slide > 0 && o.frequency.linearRampToValueAtTime(freq + slide, t + slide_speed);
o.start(t);
const stop = (time) => o.stop(time);
return { node: o, stop };