From 4d60a582fe4324eb1990128ee3058b79cc762d7a Mon Sep 17 00:00:00 2001 From: Felix Roos Date: Sun, 30 Oct 2022 18:49:26 +0100 Subject: [PATCH] note default to 36 --- packages/webaudio/webaudio.mjs | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/packages/webaudio/webaudio.mjs b/packages/webaudio/webaudio.mjs index d94f264f..ffcdd1a2 100644 --- a/packages/webaudio/webaudio.mjs +++ b/packages/webaudio/webaudio.mjs @@ -100,12 +100,8 @@ const getSoundfontKey = (s) => { const getSampleBufferSource = async (s, n, note, speed) => { let transpose = 0; - let midi; - - if (note !== undefined) { - midi = typeof note === 'string' ? toMidi(note) : note; - transpose = midi - 36; // C3 is middle C - } + let midi = typeof note === 'string' ? toMidi(note) : note || 36; + transpose = midi - 36; // C3 is middle C const ac = getAudioContext(); // is sample from loaded samples(..) @@ -128,9 +124,6 @@ const getSampleBufferSource = async (s, n, note, speed) => { if (Array.isArray(bank)) { sampleUrl = bank[n % bank.length]; } else { - if (!note) { - throw new Error('no note(...) set for sound', s); - } const midiDiff = (noteA) => toMidi(noteA) - midi; // object format will expect keys as notes const closest = Object.keys(bank)