elias/strudel
1
0
Fork 0
mirror of https://github.com/eliasstepanik/strudel.git synced 2026-01-14 15:18:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIXES: note2pc TODOs

Browse Source
This commit is contained in:
Bernhard Wagner 2023-07-14 14:38:26 +02:00
parent a3fdfbbc16
commit 4298e582fb
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/tonal/test/tonleiter.test.mjs
View File

@ -80,9 +80,9 @@ describe('tonleiter', () => {
});
test('note2pc', () => {
expect(note2pc('C5')).toBe('C');
// expect(note2pc('C52')).toBe('C'); // <- 2 digits fail
expect(note2pc('C52')).toBe('C');
expect(note2pc('Bb3')).toBe('Bb');
//expect(note2pc('F')).toBe('F'); // <- fails
expect(note2pc('F')).toBe('F');
});
test('note2oct', () => {
expect(note2oct('C5')).toBe(5);

2
packages/tonal/tonleiter.mjs
View File

@ -27,7 +27,7 @@ export function tokenizeChord(chord) {
}
return match.slice(1);
}
export const note2pc = (note) => note.slice(0, -1);
export const note2pc = (note) => note.match(/^[A-G][#b]?/i)[0];
export const note2oct = (note) => Number(note.slice(-1));
export const note2chroma = (note) => {