From 3c4f835d8b6fb8f520c7302bff4b83d5bd2dfe5d Mon Sep 17 00:00:00 2001
From: Felix Roos <flix91@gmail.com>
Date: Thu, 5 Oct 2023 00:00:47 +0200
Subject: [PATCH] consistent naming + simplify

---
 packages/superdough/reverb.mjs     | 14 +++++++-------
 packages/superdough/superdough.mjs |  6 +-----
 2 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/packages/superdough/reverb.mjs b/packages/superdough/reverb.mjs
index 52d6983c..de6c903e 100644
--- a/packages/superdough/reverb.mjs
+++ b/packages/superdough/reverb.mjs
@@ -2,9 +2,9 @@ import reverbGen from './reverbGen.mjs';
 
 if (typeof AudioContext !== 'undefined') {
   AudioContext.prototype.generateReverb = reverbGen.generateReverb;
-  AudioContext.prototype.createReverb = function (duration, fade, revlp, revdim) {
+  AudioContext.prototype.createReverb = function (duration, fade, lp, dim) {
     const convolver = this.createConvolver();
-    convolver.setDuration = (d, fade, revlp, revdim) => {
+    convolver.generate = (d, fade, lp, dim) => {
       this.generateReverb(
         {
           audioContext: this,
@@ -12,8 +12,8 @@ if (typeof AudioContext !== 'undefined') {
           numChannels: 2,
           decayTime: d,
           fadeInTime: fade,
-          lpFreqStart: revlp,
-          lpFreqEnd: revdim,
+          lpFreqStart: lp,
+          lpFreqEnd: dim,
         },
         (buffer) => {
           convolver.buffer = buffer;
@@ -21,10 +21,10 @@ if (typeof AudioContext !== 'undefined') {
       );
       convolver.duration = d;
       convolver.fade = fade;
-      convolver.revlp = revlp;
-      convolver.revdim = revdim;
+      convolver.lp = lp;
+      convolver.dim = dim;
     };
-    convolver.setDuration(duration, fade, revlp, revdim);
+    convolver.generate(duration, fade, lp, dim);
     return convolver;
   };
 }
diff --git a/packages/superdough/superdough.mjs b/packages/superdough/superdough.mjs
index 0f2b3dd0..ea8afc58 100644
--- a/packages/superdough/superdough.mjs
+++ b/packages/superdough/superdough.mjs
@@ -123,11 +123,7 @@ function getReverb(orbit, duration = 2, fade, lp, dim) {
     reverbs[orbit].lp !== lp ||
     reverbs[orbit].dim !== dim
   ) {
-    reverbs[orbit].setDuration(duration, fade, lp, dim);
-    reverbs[orbit].duration = duration;
-    reverbs[orbit].fade = fade;
-    reverbs[orbit].lp = lp;
-    reverbs[orbit].dim = dim;
+    reverbs[orbit].generate(duration, fade, lp, dim);
   }
 
   return reverbs[orbit];