From 7a999de60289c7aee83321535d294e821260079a Mon Sep 17 00:00:00 2001 From: Felix Roos Date: Fri, 11 Aug 2023 00:04:09 +0200 Subject: [PATCH] fix: always run previous trigger + make dominantTrigger more dominant --- packages/core/pattern.mjs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/core/pattern.mjs b/packages/core/pattern.mjs index f3557a3f..7e694f49 100644 --- a/packages/core/pattern.mjs +++ b/packages/core/pattern.mjs @@ -783,13 +783,14 @@ export class Pattern { hap.setContext({ ...hap.context, onTrigger: (...args) => { - if (!dominant && hap.context.onTrigger) { - hap.context.onTrigger(...args); - } + // run previously set trigger, if it exists + hap.context.onTrigger?.(...args); onTrigger(...args); }, - // we need this to know later if the default trigger should still fire - dominantTrigger: dominant, + // if dominantTrigger is set to true, the default output (webaudio) will be disabled + // when using multiple triggers, you cannot flip this flag to false again! + // example: x.csound('CooLSynth').log() as well as x.log().csound('CooLSynth') should work the same + dominantTrigger: hap.context.dominantTrigger || dominant, }), ); }