From ba9562f000db46f83c0ba8a23069e96e46a86427 Mon Sep 17 00:00:00 2001 From: Matthew Kaney Date: Mon, 3 Jul 2023 10:52:06 -0400 Subject: [PATCH] Remove highlights when code stops --- packages/react/src/hooks/useHighlighting.mjs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/react/src/hooks/useHighlighting.mjs b/packages/react/src/hooks/useHighlighting.mjs index a678fdc5..5881269c 100644 --- a/packages/react/src/hooks/useHighlighting.mjs +++ b/packages/react/src/hooks/useHighlighting.mjs @@ -20,10 +20,9 @@ function useHighlighting({ view, pattern, active, getTime }) { highlights.current = highlights.current.filter((hap) => hap.endClipped > audioTime); // keep only highlights that are still active const haps = pattern.queryArc(...span).filter((hap) => hap.hasOnset()); highlights.current = highlights.current.concat(haps); // add potential new onsets - // view.dispatch({ effects: setHighlights.of({ haps: highlights.current }) }); // highlight all still active + new active haps - highlightMiniLocations(view, highlights.current); // <- new method, replaces above line when done + highlightMiniLocations(view, highlights.current); } catch (err) { - view.dispatch({ effects: setHighlights.of({ haps: [] }) }); + highlightMiniLocations(view, []) } frame = requestAnimationFrame(updateHighlights); }); @@ -31,8 +30,7 @@ function useHighlighting({ view, pattern, active, getTime }) { cancelAnimationFrame(frame); }; } else { - highlights.current = []; - view.dispatch({ effects: setHighlights.of({ haps: [] }) }); + highlightMiniLocations(view, []); } } }, [pattern, active, view]);