Merge pull request #218 from tidalcycles/webdirt-feature-parity

samples now have envelopes

packages/webaudio/webaudio.mjs

@@ -182,8 +182,8 @@ Pattern.prototype.out = function () {
         shape,
         pan,
         attack = 0.001,
-        decay = 0.05,
-        sustain = 0.5,
+        decay = 0.001,
+        sustain = 1,
         release = 0.001,
         speed = 1, // sample playback speed
         begin = 0,
@@ -284,18 +284,9 @@ Pattern.prototype.out = function () {
           cutGroups[cut] = bufferSource;
         }
         chain.push(bufferSource);
-        if (soundfont || clip) {
-          const env = ac.createGain();
-          const releaseLength = 0.1;
-          env.gain.value = 0.6;
-          env.gain.setValueAtTime(env.gain.value, t + duration);
-          env.gain.linearRampToValueAtTime(0, t + duration + releaseLength);
-          // env.gain.linearRampToValueAtTime(0, t + duration + releaseLength);
-          chain.push(env);
-          bufferSource.stop(t + duration + releaseLength);
-        } else {
-          bufferSource.stop(t + duration);
-        }
+        bufferSource.stop(t + duration + release);
+        const adsr = getADSR(attack, decay, sustain, release, 1, t, t + duration);
+        chain.push(adsr);
       }
       // master out
       const master = ac.createGain();

repl/src/prebake.mjs

@@ -54,6 +54,7 @@ const panwidth = (pan, width) => pan * width + (1 - width) / 2;
 Pattern.prototype.piano = function () {
   return this.clip(1)
     .s('piano')
+    .release(.1)
     .fmap((value) => {
       const midi = typeof value.note === 'string' ? toMidi(value.note) : value.note;
       // pan by pitch