From 68ab43b3ab2c79691e55e3cf2ca288573bc00e72 Mon Sep 17 00:00:00 2001
From: Felix Roos <flix91@gmail.com>
Date: Wed, 27 Sep 2023 21:26:24 +0200
Subject: [PATCH] support midi clock via "clock" control (not on desktop yet)

---
 packages/core/controls.mjs |  1 +
 packages/midi/midi.mjs     | 19 +++++++++++++++++--
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/packages/core/controls.mjs b/packages/core/controls.mjs
index 6cac6e54..62cfdd46 100644
--- a/packages/core/controls.mjs
+++ b/packages/core/controls.mjs
@@ -1066,6 +1066,7 @@ const generic_params = [
    */
   ['waveloss'],
   // TODO: midi effects?
+  ['clock'],
   ['dur'],
   // ['modwheel'],
   ['expression'],
diff --git a/packages/midi/midi.mjs b/packages/midi/midi.mjs
index 98509b46..32583d75 100644
--- a/packages/midi/midi.mjs
+++ b/packages/midi/midi.mjs
@@ -90,6 +90,13 @@ Pattern.prototype.midi = function (output) {
   enableWebMidi({
     onEnabled: ({ outputs }) => {
       const device = getDevice(output, outputs);
+      if (typeof window !== 'undefined') {
+        window.addEventListener('message', (e) => {
+          if (e.data === 'strudel-stop') {
+            device.sendStop();
+          }
+        });
+      }
       const otherOutputs = outputs.filter((o) => o.name !== device.name);
       logger(
         `Midi enabled! Using "${device.name}". ${
@@ -103,6 +110,7 @@ Pattern.prototype.midi = function (output) {
 
   return this.onTrigger((time, hap, currentTime, cps) => {
     if (!WebMidi.enabled) {
+      console.log('not enabled');
       return;
     }
     const device = getDevice(output, WebMidi.outputs);
@@ -113,7 +121,7 @@ Pattern.prototype.midi = function (output) {
     const timeOffsetString = `+${offset}`;
 
     // destructure value
-    const { note, nrpnn, nrpv, ccn, ccv, midichan = 1 } = hap.value;
+    const { note, nrpnn, nrpv, ccn, ccv, midichan = 1, clock } = hap.value;
     const velocity = hap.context?.velocity ?? 0.9; // TODO: refactor velocity
 
     // note off messages will often a few ms arrive late, try to prevent glitching by subtracting from the duration length
@@ -125,7 +133,7 @@ Pattern.prototype.midi = function (output) {
         time: timeOffsetString,
       });
     }
-    if (ccv && ccn) {
+    if (ccv !== undefined && ccn !== undefined) {
       if (typeof ccv !== 'number' || ccv < 0 || ccv > 1) {
         throw new Error('expected ccv to be a number between 0 and 1');
       }
@@ -135,5 +143,12 @@ Pattern.prototype.midi = function (output) {
       const scaled = Math.round(ccv * 127);
       device.sendControlChange(ccn, scaled, midichan, { time: timeOffsetString });
     }
+    const begin = hap.whole.begin + 0;
+    if (begin === 0) {
+      device.sendStart({ time: timeOffsetString });
+    }
+    if (clock) {
+      device.sendClock({ time: timeOffsetString });
+    }
   });
 };