From e167300194b8734b0f868c479310e1f5eb4fa9b8 Mon Sep 17 00:00:00 2001 From: alex Date: Tue, 21 Jun 2022 12:15:35 +0100 Subject: [PATCH 1/2] add created param to controls --- packages/core/controls.mjs | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/core/controls.mjs b/packages/core/controls.mjs index c6f96263..c7fc932a 100644 --- a/packages/core/controls.mjs +++ b/packages/core/controls.mjs @@ -765,6 +765,7 @@ generic_params.forEach(([type, name, description]) => { // create custom param controls.createParam = (name) => { + controls[name] = (...pats) => _name(name, ...pats); Pattern.prototype[name] = _setter(controls[name], name); return (...pats) => _name(name, ...pats); }; From f6c04f9e745e69fa0c2506c161c4aed1b567565f Mon Sep 17 00:00:00 2001 From: alex Date: Tue, 21 Jun 2022 12:53:00 +0100 Subject: [PATCH 2/2] no need to involve controls[name] --- packages/core/controls.mjs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/controls.mjs b/packages/core/controls.mjs index c7fc932a..dd265d45 100644 --- a/packages/core/controls.mjs +++ b/packages/core/controls.mjs @@ -765,8 +765,8 @@ generic_params.forEach(([type, name, description]) => { // create custom param controls.createParam = (name) => { - controls[name] = (...pats) => _name(name, ...pats); - Pattern.prototype[name] = _setter(controls[name], name); + const func = (...pats) => _name(name, ...pats); + Pattern.prototype[name] = _setter(func, name); return (...pats) => _name(name, ...pats); };