consistent naming + simplify

This commit is contained in:
Felix Roos 2023-10-05 00:00:47 +02:00
parent ce842f7561
commit 3c4f835d8b
2 changed files with 8 additions and 12 deletions

View File

@ -2,9 +2,9 @@ import reverbGen from './reverbGen.mjs';
if (typeof AudioContext !== 'undefined') { if (typeof AudioContext !== 'undefined') {
AudioContext.prototype.generateReverb = reverbGen.generateReverb; AudioContext.prototype.generateReverb = reverbGen.generateReverb;
AudioContext.prototype.createReverb = function (duration, fade, revlp, revdim) { AudioContext.prototype.createReverb = function (duration, fade, lp, dim) {
const convolver = this.createConvolver(); const convolver = this.createConvolver();
convolver.setDuration = (d, fade, revlp, revdim) => { convolver.generate = (d, fade, lp, dim) => {
this.generateReverb( this.generateReverb(
{ {
audioContext: this, audioContext: this,
@ -12,8 +12,8 @@ if (typeof AudioContext !== 'undefined') {
numChannels: 2, numChannels: 2,
decayTime: d, decayTime: d,
fadeInTime: fade, fadeInTime: fade,
lpFreqStart: revlp, lpFreqStart: lp,
lpFreqEnd: revdim, lpFreqEnd: dim,
}, },
(buffer) => { (buffer) => {
convolver.buffer = buffer; convolver.buffer = buffer;
@ -21,10 +21,10 @@ if (typeof AudioContext !== 'undefined') {
); );
convolver.duration = d; convolver.duration = d;
convolver.fade = fade; convolver.fade = fade;
convolver.revlp = revlp; convolver.lp = lp;
convolver.revdim = revdim; convolver.dim = dim;
}; };
convolver.setDuration(duration, fade, revlp, revdim); convolver.generate(duration, fade, lp, dim);
return convolver; return convolver;
}; };
} }

View File

@ -123,11 +123,7 @@ function getReverb(orbit, duration = 2, fade, lp, dim) {
reverbs[orbit].lp !== lp || reverbs[orbit].lp !== lp ||
reverbs[orbit].dim !== dim reverbs[orbit].dim !== dim
) { ) {
reverbs[orbit].setDuration(duration, fade, lp, dim); reverbs[orbit].generate(duration, fade, lp, dim);
reverbs[orbit].duration = duration;
reverbs[orbit].fade = fade;
reverbs[orbit].lp = lp;
reverbs[orbit].dim = dim;
} }
return reverbs[orbit]; return reverbs[orbit];