From ed7763df921fa2cc6787adefdc92ac22568445dc Mon Sep 17 00:00:00 2001 From: Felix Roos Date: Sat, 25 Feb 2023 14:13:39 +0100 Subject: [PATCH 1/2] fix: reify after sequence to preserve array ref https://github.com/tidalcycles/strudel/issues/383#issuecomment-1399514090 --- packages/core/pattern.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/pattern.mjs b/packages/core/pattern.mjs index 1274e760..f8213380 100644 --- a/packages/core/pattern.mjs +++ b/packages/core/pattern.mjs @@ -1632,7 +1632,6 @@ export function register(name, func) { }; Pattern.prototype[name] = function (...args) { - args = args.map(reify); // For methods that take a single argument (plus 'this'), allow // multiple arguments but sequence them if (arity === 2 && args.length !== 1) { @@ -1640,6 +1639,7 @@ export function register(name, func) { } else if (arity !== args.length + 1) { throw new Error(`.${name}() expects ${arity - 1} inputs but got ${args.length}.`); } + args = args.map(reify); return pfunc(...args, this); }; From 7ac0cdc0f92bc2d147e071c10a8ab9fa875455ed Mon Sep 17 00:00:00 2001 From: Felix Roos Date: Sat, 25 Feb 2023 14:18:23 +0100 Subject: [PATCH 2/2] fix: lint error --- package.json | 7 ++++--- pnpm-lock.yaml | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index d072b0a4..b06f37a3 100644 --- a/package.json +++ b/package.json @@ -46,14 +46,15 @@ }, "homepage": "https://strudel.tidalcycles.org", "dependencies": { - "dependency-tree": "^9.0.0", - "vitest": "^0.25.7", "@strudel.cycles/core": "workspace:*", "@strudel.cycles/mini": "workspace:*", "@strudel.cycles/tonal": "workspace:*", "@strudel.cycles/transpiler": "workspace:*", "@strudel.cycles/webaudio": "workspace:*", - "@strudel.cycles/xen": "workspace:*" + "@strudel.cycles/xen": "workspace:*", + "acorn": "^8.8.1", + "dependency-tree": "^9.0.0", + "vitest": "^0.25.7" }, "devDependencies": { "@vitest/ui": "^0.25.7", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index df59deb2..9694f77f 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -11,6 +11,7 @@ importers: '@strudel.cycles/webaudio': workspace:* '@strudel.cycles/xen': workspace:* '@vitest/ui': ^0.25.7 + acorn: ^8.8.1 c8: ^7.12.0 canvas: ^2.11.0 dependency-tree: ^9.0.0 @@ -32,6 +33,7 @@ importers: '@strudel.cycles/transpiler': link:packages/transpiler '@strudel.cycles/webaudio': link:packages/webaudio '@strudel.cycles/xen': link:packages/xen + acorn: 8.8.2 dependency-tree: 9.0.0 vitest: 0.25.8_@vitest+ui@0.25.8 devDependencies: