From 1043baf08a0da3acd89997f9ba71e8caff05c29e Mon Sep 17 00:00:00 2001 From: Felix Roos Date: Fri, 15 Mar 2024 12:24:03 +0100 Subject: [PATCH] fix: catch errors in pianoroll getValue --- packages/draw/pianoroll.mjs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/draw/pianoroll.mjs b/packages/draw/pianoroll.mjs index 29c61d18..2ec2d7ee 100644 --- a/packages/draw/pianoroll.mjs +++ b/packages/draw/pianoroll.mjs @@ -18,7 +18,13 @@ const getValue = (e) => { } note = note ?? n; if (typeof note === 'string') { - return noteToMidi(note); + try { + // TODO: n(run(32)).scale("D:minor") fails when trying to query negative time.. + return noteToMidi(note); + } catch (err) { + // console.warn(`error converting note to midi: ${err}`); // this spams to crazy + return 0; + } } if (typeof note === 'number') { return note;