diff --git a/imgui-examples/examples/support/mod.rs b/imgui-examples/examples/support/mod.rs index c5308ae..57e8706 100644 --- a/imgui-examples/examples/support/mod.rs +++ b/imgui-examples/examples/support/mod.rs @@ -1,7 +1,7 @@ use glium::glutin::{self, Event, WindowEvent}; use glium::{Display, Surface}; use imgui::{Context, FontConfig, FontGlyphRanges, FontSource, Ui}; -use imgui_glium_renderer::GliumRenderer; +use imgui_glium_renderer::Renderer; use imgui_winit_support::{HiDpiMode, WinitPlatform}; use std::time::Instant; @@ -12,7 +12,7 @@ pub struct System { pub display: glium::Display, pub imgui: Context, pub platform: WinitPlatform, - pub renderer: GliumRenderer, + pub renderer: Renderer, pub font_size: f32, } @@ -67,8 +67,7 @@ pub fn init(title: &str) -> System { imgui.io_mut().font_global_scale = (1.0 / hidpi_factor) as f32; - let renderer = - GliumRenderer::init(&mut imgui, &display).expect("Failed to initialize renderer"); + let renderer = Renderer::init(&mut imgui, &display).expect("Failed to initialize renderer"); System { events_loop, diff --git a/imgui-gfx-examples/examples/support/mod.rs b/imgui-gfx-examples/examples/support/mod.rs index 0ecb8e8..f58a905 100644 --- a/imgui-gfx-examples/examples/support/mod.rs +++ b/imgui-gfx-examples/examples/support/mod.rs @@ -1,7 +1,7 @@ use gfx::Device; use glutin::{Event, WindowEvent}; use imgui::{Context, FontConfig, FontGlyphRanges, FontSource, Ui}; -use imgui_gfx_renderer::{GfxRenderer, Shaders}; +use imgui_gfx_renderer::{Renderer, Shaders}; use imgui_winit_support::{HiDpiMode, WinitPlatform}; use std::time::Instant; @@ -125,7 +125,7 @@ mod types { #[cfg(feature = "opengl")] pub struct RenderSystem { - pub renderer: GfxRenderer, + pub renderer: Renderer, pub windowed_context: glutin::WindowedContext, pub device: types::Device, pub factory: types::Factory, @@ -181,7 +181,7 @@ impl RenderSystem { } }; let renderer = - GfxRenderer::init(imgui, &mut factory, shaders).expect("Failed to initialize renderer"); + Renderer::init(imgui, &mut factory, shaders).expect("Failed to initialize renderer"); RenderSystem { renderer, windowed_context, @@ -217,7 +217,7 @@ mod types { #[cfg(feature = "directx")] pub struct RenderSystem { - pub renderer: GfxRenderer, + pub renderer: Renderer, pub window: gfx_window_dxgi::Window, pub device: types::Device, pub factory: types::Factory, @@ -233,7 +233,7 @@ impl RenderSystem { ) -> RenderSystem { let (window, device, mut factory, main_color) = gfx_window_dxgi::init(builder, &events_loop).expect("Failed to initialize graphics"); - let renderer = GfxRenderer::init(imgui, &mut factory, Shaders::HlslSm40) + let renderer = Renderer::init(imgui, &mut factory, Shaders::HlslSm40) .expect("Failed to initialize renderer"); RenderSystem { renderer, diff --git a/imgui-gfx-renderer/src/lib.rs b/imgui-gfx-renderer/src/lib.rs index b2ea667..9c7dc76 100644 --- a/imgui-gfx-renderer/src/lib.rs +++ b/imgui-gfx-renderer/src/lib.rs @@ -10,7 +10,7 @@ use imgui::{DrawCmd, DrawCmdParams, DrawData, DrawIdx, DrawVert, ImString, Textu use std::usize; #[derive(Clone, Debug)] -pub enum GfxRendererError { +pub enum RendererError { Update(gfx::UpdateError), Buffer(gfx::buffer::CreationError), Pipeline(gfx::PipelineStateError), @@ -18,27 +18,27 @@ pub enum GfxRendererError { BadTexture(TextureId), } -impl From> for GfxRendererError { - fn from(e: gfx::UpdateError) -> GfxRendererError { - GfxRendererError::Update(e) +impl From> for RendererError { + fn from(e: gfx::UpdateError) -> RendererError { + RendererError::Update(e) } } -impl From for GfxRendererError { - fn from(e: gfx::buffer::CreationError) -> GfxRendererError { - GfxRendererError::Buffer(e) +impl From for RendererError { + fn from(e: gfx::buffer::CreationError) -> RendererError { + RendererError::Buffer(e) } } -impl From> for GfxRendererError { - fn from(e: gfx::PipelineStateError) -> GfxRendererError { - GfxRendererError::Pipeline(e) +impl From> for RendererError { + fn from(e: gfx::PipelineStateError) -> RendererError { + RendererError::Pipeline(e) } } -impl From for GfxRendererError { - fn from(e: gfx::CombinedError) -> GfxRendererError { - GfxRendererError::Combined(e) +impl From for RendererError { + fn from(e: gfx::CombinedError) -> RendererError { + RendererError::Combined(e) } } @@ -101,7 +101,7 @@ pub type Texture = ( gfx::handle::Sampler, ); -pub struct GfxRenderer { +pub struct Renderer { vertex_buffer: Buffer, index_buffer: Buffer, slice: Slice, @@ -112,7 +112,7 @@ pub struct GfxRenderer { constants: Buffer, } -impl GfxRenderer +impl Renderer where Cf: BlendFormat, R: Resources, @@ -121,7 +121,7 @@ where ctx: &mut imgui::Context, factory: &mut F, shaders: Shaders, - ) -> Result, GfxRendererError> { + ) -> Result, RendererError> { let (vs_code, ps_code) = shaders.get_program_code(); let pso = factory.create_pipeline_simple(vs_code, ps_code, pipeline::new::())?; let vertex_buffer = factory.create_buffer::( @@ -148,7 +148,7 @@ where "imgui-gfx-renderer {}", env!("CARGO_PKG_VERSION") )))); - Ok(GfxRenderer { + Ok(Renderer { vertex_buffer, index_buffer, slice, @@ -163,7 +163,7 @@ where &mut self, ctx: &mut imgui::Context, factory: &mut F, - ) -> Result<(), GfxRendererError> { + ) -> Result<(), RendererError> { self.font_texture = upload_font_texture(ctx.fonts(), factory)?; Ok(()) } @@ -176,7 +176,7 @@ where encoder: &mut Encoder, target: &mut RenderTargetView, draw_data: &DrawData, - ) -> Result<(), GfxRendererError> { + ) -> Result<(), RendererError> { let fb_width = draw_data.display_size[0] * draw_data.framebuffer_scale[0]; let fb_height = draw_data.display_size[1] * draw_data.framebuffer_scale[1]; if !(fb_width > 0.0 && fb_height > 0.0) { @@ -268,7 +268,7 @@ where factory: &mut F, encoder: &mut Encoder, vtx_buffer: &[DrawVert], - ) -> Result<(), GfxRendererError> { + ) -> Result<(), RendererError> { if self.vertex_buffer.len() < vtx_buffer.len() { self.vertex_buffer = factory.create_buffer::( vtx_buffer.len(), @@ -285,7 +285,7 @@ where factory: &mut F, encoder: &mut Encoder, idx_buffer: &[DrawIdx], - ) -> Result<(), GfxRendererError> { + ) -> Result<(), RendererError> { if self.index_buffer.len() < idx_buffer.len() { self.index_buffer = factory.create_buffer::( idx_buffer.len(), @@ -298,13 +298,13 @@ where encoder.update_buffer(&self.index_buffer, idx_buffer, 0)?; Ok(()) } - fn lookup_texture(&self, texture_id: TextureId) -> Result<&Texture, GfxRendererError> { + fn lookup_texture(&self, texture_id: TextureId) -> Result<&Texture, RendererError> { if texture_id.id() == usize::MAX { Ok(&self.font_texture) } else if let Some(texture) = self.textures.get(texture_id) { Ok(texture) } else { - Err(GfxRendererError::BadTexture(texture_id)) + Err(RendererError::BadTexture(texture_id)) } } } @@ -312,7 +312,7 @@ where fn upload_font_texture>( mut fonts: imgui::FontAtlasRefMut, factory: &mut F, -) -> Result, GfxRendererError> { +) -> Result, RendererError> { let texture = fonts.build_rgba32_texture(); let (_, texture_view) = factory.create_texture_immutable_u8::( gfx::texture::Kind::D2( diff --git a/imgui-glium-renderer/src/lib.rs b/imgui-glium-renderer/src/lib.rs index 4983961..5e1cc3f 100644 --- a/imgui-glium-renderer/src/lib.rs +++ b/imgui-glium-renderer/src/lib.rs @@ -15,7 +15,7 @@ use std::rc::Rc; use std::usize; #[derive(Clone, Debug)] -pub enum GliumRendererError { +pub enum RendererError { Vertex(vertex::BufferCreationError), Index(index::BufferCreationError), Program(ProgramChooserCreationError), @@ -24,9 +24,9 @@ pub enum GliumRendererError { BadTexture(TextureId), } -impl fmt::Display for GliumRendererError { +impl fmt::Display for RendererError { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - use self::GliumRendererError::*; + use self::RendererError::*; match *self { Vertex(_) => write!(f, "Vertex buffer creation failed"), Index(_) => write!(f, "Index buffer creation failed"), @@ -38,85 +38,82 @@ impl fmt::Display for GliumRendererError { } } -impl From for GliumRendererError { - fn from(e: vertex::BufferCreationError) -> GliumRendererError { - GliumRendererError::Vertex(e) +impl From for RendererError { + fn from(e: vertex::BufferCreationError) -> RendererError { + RendererError::Vertex(e) } } -impl From for GliumRendererError { - fn from(e: index::BufferCreationError) -> GliumRendererError { - GliumRendererError::Index(e) +impl From for RendererError { + fn from(e: index::BufferCreationError) -> RendererError { + RendererError::Index(e) } } -impl From for GliumRendererError { - fn from(e: ProgramChooserCreationError) -> GliumRendererError { - GliumRendererError::Program(e) +impl From for RendererError { + fn from(e: ProgramChooserCreationError) -> RendererError { + RendererError::Program(e) } } -impl From for GliumRendererError { - fn from(e: TextureCreationError) -> GliumRendererError { - GliumRendererError::Texture(e) +impl From for RendererError { + fn from(e: TextureCreationError) -> RendererError { + RendererError::Texture(e) } } -impl From for GliumRendererError { - fn from(e: DrawError) -> GliumRendererError { - GliumRendererError::Draw(e) +impl From for RendererError { + fn from(e: DrawError) -> RendererError { + RendererError::Draw(e) } } -pub struct GliumRenderer { +pub struct Renderer { ctx: Rc, program: Program, font_texture: Texture2d, textures: Textures>, } -impl GliumRenderer { +impl Renderer { pub fn init( ctx: &mut imgui::Context, facade: &F, - ) -> Result { + ) -> Result { let program = compile_default_program(facade)?; let font_texture = upload_font_texture(ctx.fonts(), facade.get_context())?; ctx.set_renderer_name(Some(ImString::from(format!( "imgui-glium-renderer {}", env!("CARGO_PKG_VERSION") )))); - Ok(GliumRenderer { + Ok(Renderer { ctx: Rc::clone(facade.get_context()), program, font_texture, textures: Textures::new(), }) } - pub fn reload_font_texture( - &mut self, - ctx: &mut imgui::Context, - ) -> Result<(), GliumRendererError> { + pub fn reload_font_texture(&mut self, ctx: &mut imgui::Context) -> Result<(), RendererError> { self.font_texture = upload_font_texture(ctx.fonts(), &self.ctx)?; Ok(()) } pub fn textures(&mut self) -> &mut Textures> { &mut self.textures } - fn lookup_texture(&self, texture_id: TextureId) -> Result<&Texture2d, GliumRendererError> { + fn lookup_texture(&self, texture_id: TextureId) -> Result<&Texture2d, RendererError> { if texture_id.id() == usize::MAX { Ok(&self.font_texture) } else if let Some(texture) = self.textures.get(texture_id) { Ok(texture) } else { - Err(GliumRendererError::BadTexture(texture_id)) + Err(RendererError::BadTexture(texture_id)) } } pub fn render( &mut self, target: &mut T, draw_data: &DrawData, - ) -> Result<(), GliumRendererError> { + ) -> Result<(), RendererError> { let fb_width = draw_data.display_size[0] * draw_data.framebuffer_scale[0]; let fb_height = draw_data.display_size[1] * draw_data.framebuffer_scale[1]; if !(fb_width > 0.0 && fb_height > 0.0) { @@ -214,7 +211,7 @@ impl GliumRenderer { fn upload_font_texture( mut fonts: imgui::FontAtlasRefMut, ctx: &Rc, -) -> Result { +) -> Result { let texture = fonts.build_rgba32_texture(); let data = RawImage2d { data: Cow::Borrowed(texture.data),