From bae12a500c01cf5e9da79890f5239e44be375db4 Mon Sep 17 00:00:00 2001 From: Michael Smith Date: Sun, 13 Mar 2016 22:57:37 -0700 Subject: [PATCH] Fix for a regression in length/width/height assignment on cubes due to binding refactoring --- OSCADSharp/OSCADSharp.UnitTests/Solids/CubeTests.cs | 10 ++++++++++ .../Internal/Scripting/Solids/CubeScriptBuilder.cs | 4 ++++ 2 files changed, 14 insertions(+) diff --git a/OSCADSharp/OSCADSharp.UnitTests/Solids/CubeTests.cs b/OSCADSharp/OSCADSharp.UnitTests/Solids/CubeTests.cs index 3e5d67a..6f591ad 100644 --- a/OSCADSharp/OSCADSharp.UnitTests/Solids/CubeTests.cs +++ b/OSCADSharp/OSCADSharp.UnitTests/Solids/CubeTests.cs @@ -190,5 +190,15 @@ namespace OSCADSharp.UnitTests Assert.IsTrue(script.Contains("translate(v = [xOffset")); Assert.IsTrue(script.Contains("size = [15, 5, myHeight]")); } + + [TestMethod] + public void Cube_LengthWidthHeightAppearsInScriptOutput() + { + var cube = new Cube(15, 5, 12); + + string script = cube.ToString(); + + Assert.IsTrue(script.Contains("size = [15, 5, 12]")); + } } } diff --git a/OSCADSharp/OSCADSharp/Internal/Scripting/Solids/CubeScriptBuilder.cs b/OSCADSharp/OSCADSharp/Internal/Scripting/Solids/CubeScriptBuilder.cs index 115bb61..f2e26a8 100644 --- a/OSCADSharp/OSCADSharp/Internal/Scripting/Solids/CubeScriptBuilder.cs +++ b/OSCADSharp/OSCADSharp/Internal/Scripting/Solids/CubeScriptBuilder.cs @@ -19,6 +19,10 @@ namespace OSCADSharp internal string GetScript() { + this.bindings.SizeBinding.X = this.cube.Size.X; + this.bindings.SizeBinding.Y = this.cube.Size.Y; + this.bindings.SizeBinding.Z = this.cube.Size.Z; + return String.Format("cube(size = {0}, center = {1}); {2}", this.bindings.SizeBinding.ToString(), this.bindings.CenterBinding.IsBound ? this.bindings.CenterBinding.ToString() :