elias/OSCADSharpDotnet7
1
0
Fork 0
mirror of https://github.com/eliasstepanik/OSCADSharpDotnet7.git synced 2026-01-18 17:08:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

+ Added a NotSupportedException when Position is called on a mirrored object that's been mirrored on multiple axes + test

Browse Source
This commit is contained in:
Michael L Smith 2016-02-16 19:34:33 -08:00
parent 8e5aa0a2f3
commit 2bbe452da6
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
OSCADSharp/OSCADSharp.UnitTests/MirrorTests.cs
View File

@ -31,5 +31,14 @@ namespace OSCADSharp.UnitTests
pos.Z = -pos.Z; pos.Z = -pos.Z;
Assert.AreEqual(pos, zMirror.Position()); Assert.AreEqual(pos, zMirror.Position());
} }
[TestMethod]
[ExpectedException(typeof(NotSupportedException))]
public void Mirror_MultiAxisPositionThrowsNotSupportedException()
{
var cube = new Cube(5, 10, 20);
var pos = cube.Mirror(1, 1, 0).Position();
}
} }
} }

11
OSCADSharp/OSCADSharp/Transforms/MirroredObject.cs
View File

@ -55,6 +55,11 @@ namespace OSCADSharp.Transforms
// fix mirrored positions for multiple-axis mirroring // fix mirrored positions for multiple-axis mirroring
public override Vector3 Position() public override Vector3 Position()
{ {
if (this.isMoreThanOneAxis())
{
throw new NotSupportedException("Getting the position of an object that's been mirrored on more than one axis is not currently supported.");
}
var pos = obj.Position(); var pos = obj.Position();
double x = this.Normal.X != 0 ? pos.X * -1 : pos.X; double x = this.Normal.X != 0 ? pos.X * -1 : pos.X;
@ -63,5 +68,11 @@ namespace OSCADSharp.Transforms
return new Vector3(x, y, z); return new Vector3(x, y, z);
} }
private bool isMoreThanOneAxis()
{
return (this.Normal.X != 0 && (this.Normal.Y != 0 || this.Normal.Z != 0)) ||
(this.Normal.Y != 0 && (this.Normal.X != 0 || this.Normal.Z != 0));
}
} }
} }